Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugins writeable #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make plugins writeable #442

wants to merge 1 commit into from

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Jan 17, 2025

What it does

Follow up of #440
Checksums looked right and we were able to debug further.
It looks like some files in the Java VSIX are not writable and the Mac Updater tries to change permissions there, leading to a failure.

  • make sure that plugin files are writable so that Mac may set/remove quarantine bits
  • also bump patch versions

Again, this Preview will probably not be promoted, Changes will go live with 1.58

How to test

Review checklist

Reminder for reviewers

* make sure that files are writeable so that Mac may set/remove
quarantine bits
* also bump patch versions
@jfaltermeier jfaltermeier marked this pull request as ready for review January 17, 2025 11:19
@jfaltermeier jfaltermeier requested a review from sgraband January 17, 2025 11:19
Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants