-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-1377: Extract move and zoom features from accessibility to own module #396
base: master
Are you sure you want to change the base?
GH-1377: Extract move and zoom features from accessibility to own module #396
Conversation
@tortmayr after some thought, do we even require tools for moving/zooming? Maybe |
@haydar-metin I agree. Currently zooming/scrolling via mouse is provided by the So we should not use tools for zooming/moving. Thinking about it maybe it even makes sense to integrate the keyboard functionality for zooming/moving/scrolling directly into the corresponding default module (viewportModule, changeBoundsToolModule) instead of having extra a11y modules for them. |
0c9ace0
to
5b3cccf
Compare
@tortmayr sounds good to me! I did the following:
|
@haydar-metin Thanks for providing this change. |
+Fix eclipse-glsp#401 Node creation (eclipse-glsp#402) + Resolve eclipse-glsp#398 Refactor TypeHints API (eclipse-glsp#399) + Resolve eclipse-glsp#396 RouterKind for FeedbackEdge (eclipse-glsp#397) + Reuse Sprotty's request/response system and remove custom solution(eclipse-glsp#404) + Add support for context menu and harmonize with command palette (eclipse-glsp#405)
+Fix eclipse-glsp#401 Node creation (eclipse-glsp#402) + Resolve eclipse-glsp#398 Refactor TypeHints API (eclipse-glsp#399) + Resolve eclipse-glsp#396 RouterKind for FeedbackEdge (eclipse-glsp#397) + Reuse Sprotty's request/response system and remove custom solution(eclipse-glsp#404) + Add support for context menu and harmonize with command palette (eclipse-glsp#405)
What it does
Works on eclipse-glsp/glsp#1377
How to test
Use the arrow keys to move the viewport / elements.
Use +/- to zoom in and out.
Follow-ups
Changelog
The move and zoom features have been moved to their own modules. They are now enabled by default.