Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'NoSetupRepoFactory' E2E test #23314

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Update 'NoSetupRepoFactory' E2E test #23314

merged 2 commits into from
Jan 17, 2025

Conversation

artaleks9
Copy link
Contributor

What does this PR do?

Fixes the NoSetupRepoFactory.spec.ts E2E test by deleting deprecated steps.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

Run the NoSetupRepoFactory.spec.ts as usual

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@artaleks9 artaleks9 added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. area/qe labels Jan 16, 2025
@artaleks9 artaleks9 requested review from SkorikSergey and removed request for musienko-maxim January 16, 2025 15:39
@artaleks9 artaleks9 self-assigned this Jan 16, 2025
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

I would only suggest opening dedicated JIRA ticket about the changes for the history.

@artaleks9 artaleks9 removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 17, 2025
@artaleks9 artaleks9 merged commit 0bc1c58 into main Jan 17, 2025
4 of 5 checks passed
@artaleks9 artaleks9 deleted the update-no-setup-factory branch January 17, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants