Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Types of Readability #775

Merged
merged 16 commits into from
Feb 13, 2024
Merged

Two Types of Readability #775

merged 16 commits into from
Feb 13, 2024

Conversation

adamgordonbell
Copy link
Contributor

@adamgordonbell adamgordonbell commented Feb 9, 2024

Copy link
Member

@vladaionescu vladaionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - just had very minor comments / corrections!

blog/_posts/2024-02-06-readability.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-06-readability.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-06-readability.md Outdated Show resolved Hide resolved
blog/_posts/2024-02-06-readability.md Outdated Show resolved Hide resolved
Val sentences = List(
"Normally you can't compose",
"M[Y] and X⇒M[Y]",
"to get M[Y]")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling that this second mention shouldn't also be M[Y] again but I don't know what it should be :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was correct, but sort of a confusing example.
I ended up changing the whole example to better show what flatmap does.


If used to more concisely express the concept at hand ( and not for showing off), all these things can improve expert readability at the cost of beginner readability.

<div class="notice--warning notice--big">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the formatting of these tables - it's like I'm reading the Financial Times haha

blog/_posts/2024-02-06-readability.md Outdated Show resolved Hide resolved
@adamgordonbell adamgordonbell merged commit 79f229b into main Feb 13, 2024
1 check passed
@adamgordonbell adamgordonbell deleted the agb/beginningread branch February 13, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants