Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for VS2019 #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zholobov
Copy link

@NPC
Copy link

NPC commented Apr 26, 2019

@zholobov
Copy link
Author

@NPC I'll take a look at the async loading. @eamodio are you okay with me potentially doing a PR (maybe as part of this one) for async loading?

@eamodio
Copy link
Owner

eamodio commented Apr 26, 2019

@zholobov 👍 Sounds great as long as it keeps support for at least 2017 at a minimum

@zholobov
Copy link
Author

@eamodio after an investigation it looks like adopting async loading would require rewriting code to use new async APIs with different assumptions on threading - i.e. making sure some VS SDK API calls are made on UI thread. I don't have time now to accomplish this major rewrite.

@tejsj
Copy link

tejsj commented May 22, 2019

imo adding support for 2019 with whatever caveats is better than no support? The async API can be rewritten if needed later on? I think this pull request should be accepted (FYI; I have made a similar change as this pull request and are not experiencing any problems at all in VS2019)

@DanJ210
Copy link

DanJ210 commented Oct 2, 2019

I see that the fork from this PR has published released for 2019 support. Thank you for the work to make this extension and the work to migrate it. Really enjoy this extension and I very much missed it. That's why I was looking it up to see if I could migrate it myself but much more advanced users than I have already done so and I'm so very glad. Thanks guys/girls!

@jcreek
Copy link

jcreek commented Dec 9, 2019

Is there a plan to merge this PR in? I can see it's been several months, but the official extension on the marketplace at https://marketplace.visualstudio.com/items?itemName=eamodio.SaveAlltheTabs still only supports up to 2017.

@marty2013
Copy link

Hi guys - looking forward to vs2019 version - whats the latest ? Needs COVID testing ? ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants