[WIP] Add AI Chat Entry Point #5415
Draft
+982
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshuba
force-pushed
the
nastia/feature/ai_chat_entry
branch
2 times, most recently
from
9ba9628 to
eaca222
Compare
nshuba
force-pushed
the
nastia/feature/ai_chat_entry
branch
from
eaca222 to
faa5cbc
Compare
aitorvs
reviewed
Jan 3, 2025
| moshi.adapter(DuckChatSettingJson::class.java) | ||
| } | ||
|
|
||
| override fun isEnabled(): Boolean { |
There was a problem hiding this comment.
Make it suspend and directly assign dispatchers.io()
Suggested change
| override fun isEnabled(): Boolean { | |
| override suspend fun isEnabled(): Boolean = withContext(dispatchers.io()) = { |
| } | ||
| } | ||
|
|
||
| override fun showInBrowserMenu(): Boolean { |
There was a problem hiding this comment.
Make it suspend and assign dispatchers.io()
| .stateIn(appCoroutineScope, SharingStarted.Eagerly, true) | ||
|
|
||
| override suspend fun setShowInBrowserMenu(showDuckChat: Boolean) { | ||
| store.edit { prefs -> prefs[DUCK_CHAT_SHOW_IN_MENU] = showDuckChat } |
There was a problem hiding this comment.
In what thread is the block inside store.edit{} executed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL:
Description
Steps to test this PR
Feature 1
UI changes