Clear entries from LevelDB #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
joshliebe
force-pushed
the
feature/aitor/webview/localStorage
branch
from
9562bfd to
af0cf12
Compare
joshliebe
force-pushed
the
feature/josh/clear-from-level-db
branch
from
37a55d2 to
8bfc686
Compare
aitorvs
reviewed
Dec 18, 2024
joshliebe
force-pushed
the
feature/josh/clear-from-level-db
branch
from
5fde4bd to
e610184
Compare
joshliebe
changed the base branch from
feature/aitor/webview/localStorage
to
develop
joshliebe
force-pushed
the
feature/josh/clear-from-level-db
branch
from
7590db5 to
627a8e3
Compare
8 tasks
aitorvs
approved these changes
Jan 6, 2025
app/src/main/java/com/duckduckgo/app/browser/localstorage/LocalStorageManager.kt
Outdated
Show resolved
Hide resolved
Comment on lines
58
to
59
| Timber.d("LocalStorageManager: Allowed domains: $domains") | ||
| Timber.d("LocalStorageManager: Matching regex: $matchingRegex") |
There was a problem hiding this comment.
Mental note, we need to migrate all logs to logcat. String interpolation will be executed in production even if logs are disabled. Which is wasteful and in hot paths perf can even be noticeable if the strings are big
No need to do anything here
| private val jsonAdapter by lazy { buildJsonAdapter() } | ||
|
|
||
| private fun buildJsonAdapter(): JsonAdapter<SettingsJson> { | ||
| val moshi = Moshi.Builder().add(KotlinJsonAdapterFactory()).build() |
There was a problem hiding this comment.
Note: I wonder if we should directly add the KotlinJsonAdapterFactory to the moshi instance that it's in DI.
I see we're creating new instances of moshi everywhere just because the DI instance doens't have that adapter
Also no need to do it in this PR
app/src/main/java/com/duckduckgo/app/pixels/remoteconfig/AndroidBrowserConfigFeature.kt
Outdated
Show resolved
Hide resolved
|
@aitorvs I’ve renamed all instances of local storage to web local storage, thanks for the review! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1208996865644937/f
Description
Selectively clears entries from the
WebView’s LevelDB.Steps to test this PR
Point at the JSON blob linked in the task
cnn.comcnn.comentries are deleted (And any other sites you may have visited), e.g.