Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example to use new Dry.Types() syntax #430

Closed
wants to merge 1 commit into from

Conversation

VikiAnn
Copy link

@VikiAnn VikiAnn commented Dec 22, 2021

Tiny docs change, just ran into a deprecation error when attempting to use the example code.

@VikiAnn
Copy link
Author

VikiAnn commented Dec 22, 2021

Hmm, so it occurred to me to run a search for any other instances of the old syntax, and I was surprised to find no examples at all - including the one in this PR. Looks like the docs published to the website are from a very old version of the gem. That's probably the actual fix needed, not this PR.

@solnic
Copy link
Member

solnic commented Dec 23, 2021

Hey, thanks for the PR - docs are versioned, so this: https://dry-rb.org/gems/dry-types/0.15/ points to dry-types 0.15.x docs and back then we had this syntax, so docs are correct.

As you didn't notice this, I suspect we could do a better job at displaying some info about the current version of docs you're reading. Maybe even add some extra notice if the docs you're reading are old 🙂 WDYT?

@VikiAnn
Copy link
Author

VikiAnn commented Jan 4, 2022

As you didn't notice this, I suspect we could do a better job at displaying some info about the current version of docs you're reading. Maybe even add some extra notice if the docs you're reading are old 🙂 WDYT?

That sounds like it would be helpful, yes :D Thank you!

@solnic
Copy link
Member

solnic commented Jan 5, 2022

I reported an issue about it so that we won't forget dry-rb/dry-rb.org#388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants