simplify CreateTempSubdirectory #45633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
3 tasks
|
@marcpopMSFT @baronfel can we backport it to 9.0.2xx? |
nagilson
reviewed
Jan 9, 2025
|
updated. it guarantees the desired file mode is set on unix without pinvoke |
nagilson
reviewed
Jan 9, 2025
nagilson
reviewed
Jan 9, 2025
omajid
reviewed
Jan 10, 2025
tmds
reviewed
Jan 10, 2025
edvilme
reviewed
Jan 13, 2025
| public override string ToString() | ||
| { | ||
| return ToQuotedString(); | ||
| return $"\"{Value}\""; |
There was a problem hiding this comment.
I don't have much context, but perhaps I would suggest using Path.DirectorySeparatorChar
There was a problem hiding this comment.
i moved it from ToQuotedString and deleted the unnecessary wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InternalAbstractionsnetstandard support is only needed byMicrosoft.NET.TestFramework.csproj. for thatCreateTempSubdirectoryis using p/invoke for all dependentsmaking
InternalAbstractionsmulti-framework same asMicrosoft.NET.TestFramework.csprojto simplifyCreateTempSubdirectoryand deleting unused methods#45631