Revert "Fix NativeAOT ThunksPool thunk data block size handling." #110983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
MichalStrehovsky
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
The only outerloop failure looks to be the known CRT bug (since we finished the test and then crashed on shutdown - I'm not going to look at the dump). Reminds me to look into #109006 once I'm back at work.
|
@lateralusX are the ARM32 failures something you could look into this week? Otherwise I'd prefer we merge the revert so that native AOT outerloop can be green again. It's very difficult to watch for regressions when every outerloop run is red. See #110852 (comment) for more context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #110732