-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Trigger OnNavigatedTo method when hide the nav bar and using swipe gesture #27186
Open
kubaflo
wants to merge
2
commits into
dotnet:main
Choose a base branch
from
kubaflo:Not-trigger-OnNavigatedTo-method-when-hide-the-navi-bar-and-using-swipe-back-on-iOS
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
namespace Maui.Controls.Sample.Issues | ||
{ | ||
|
||
[Issue(IssueTracker.Github, 27143, "Not trigger OnNavigatedTo method when hide the navi bar and using swipe", PlatformAffected.iOS)] | ||
public class Issue27143NavigationPage : NavigationPage | ||
{ | ||
public Issue27143NavigationPage() : base(new Issue27143()) { } | ||
|
||
class Issue27143 : ContentPage | ||
{ | ||
int _navigatedToEventTriggersCount; | ||
|
||
Label _label; | ||
|
||
public Issue27143() | ||
{ | ||
ContentPage subpage = new ContentPage() | ||
{ | ||
Content = new Label() | ||
{ | ||
Text = "Hello from the other side!", | ||
} | ||
}; | ||
|
||
SetHasNavigationBar(this, false); | ||
|
||
_label = new Label() | ||
{ | ||
AutomationId = "navigatedToEventTriggersCountLabel", | ||
}; | ||
|
||
Content = new VerticalStackLayout() | ||
{ | ||
new Button() | ||
{ | ||
Text = "Click to navigate", | ||
AutomationId = "button", | ||
Command = new Command(() => Window!.Page!.Navigation.PushAsync(subpage, false)) | ||
}, | ||
_label | ||
}; | ||
} | ||
|
||
protected override void OnNavigatedTo(NavigatedToEventArgs args) | ||
{ | ||
_label.Text = $"NavigatedTo event triggers count: {++_navigatedToEventTriggersCount}"; | ||
} | ||
} | ||
} | ||
} |
27 changes: 27 additions & 0 deletions
27
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27143.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
#if IOS && TEST_FAILS_ON_IOS // Remove it once you find a way to perform swipe to navigate back | ||
using NUnit.Framework; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues | ||
{ | ||
public class Issue27143 : _IssuesUITest | ||
{ | ||
public Issue27143(TestDevice testDevice) : base(testDevice) | ||
{ | ||
} | ||
|
||
public override string Issue => "Not trigger OnNavigatedTo method when hide the navi bar and using swipe"; | ||
|
||
[Test] | ||
[Category(UITestCategories.Navigation)] | ||
public void OnNavigatedToShouldTrigger() | ||
{ | ||
App.WaitForElement("button"); | ||
App.Click("button"); | ||
// Find a way to perform swipe to navigate back | ||
App.WaitForElement("NavigatedTo event triggers count: 2"); | ||
} | ||
} | ||
} | ||
#endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz do you have some idea of how we can do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anandhan-rajagopal maybe you can help here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think
App.SwipeRightToLeft
should the expected gesture.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already tried, but it doesn't work :/