Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fixed the Application crash when ToolbarItem is created with invalid IconImageSource name #27175

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[iOS] Fixed the Application crash when ToolbarItem is created with invalid IconImageSource name #27175

wants to merge 1 commit into from
+3 −5

Conversation

Ahamed-Ali
Copy link
Contributor

@Ahamed-Ali Ahamed-Ali commented Jan 16, 2025 •
edited
Loading

Root Cause of the issue

  • The exception is thrown from FileImageSourceService.iOS when the image is null, causing the application to crash if an invalid IconImageSource is provided.

Description of Change

  • Instead of throwing an exception, log the exception details and safely return to prevent the application from crashing when an invalid IconImageSource is provided.

Reference

Issues Fixed

Fixes #27095

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
WithCrash.mov
FixedWithouCrash.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 16, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 16, 2025
@Ahamed-Ali Ahamed-Ali marked this pull request as ready for review January 16, 2025 10:43
@Ahamed-Ali Ahamed-Ali requested a review from a team as a code owner January 16, 2025 10:43
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWeen PureWeen Awaiting requested review from PureWeen PureWeen is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Application crashes when ToolbarItem is created with invalid IconImageSource name
3 participants
@Ahamed-Ali @jsuarezruiz @sheiksyedm