Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install curl on the Docker image #327

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michaelfahmy
Copy link

This PR adds the curl utility to the Prometheus Exporter Docker image (ghcr.io/discourse/prometheus_exporter).

Changes Made:

  • Updated the Dockerfile to install curl during the image build process.
  • This ensures that the curl command is available in the container, which is critical for performing health checks (e.g., curl -sSf http://localhost:9394/ping).

@tgxworld
Copy link
Contributor

tgxworld commented Dec 5, 2024

  • which is critical for performing health checks (e.g., curl -sSf http://localhost:9394/ping).

Wouldn't health checks be performed from an external service connecting to a port exposed by the Docker container?

@michaelfahmy
Copy link
Author

Wouldn't health checks be performed from an external service connecting to a port exposed by the Docker container?

The image is used on AWS ECS, so I'm defining the health check for the container on the task definition, which is running on the same host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants