Re-write diagnostics in React #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing Ember app was using a 5 year old Ember release, and I am far more comfortable with React in order to further build out this functionality.
benlangfeld
force-pushed
the
improved-diagnostics
branch
from
f91d015 to
0fe0124
Compare
jeremyevans
reviewed
Dec 6, 2018
|
Nothing is fundamentally wrong here 👍 only suggestion I have is can you include screenshots as you go, it makes it easier to provide quick feedback |
|
I will include screenshots as I work. Right now, this has feature parity with the Ember version and looks the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the beginning of #186. Submitting it right away just in case there's some fundamental issue before I really get stuck in.