DEV: update component to be compatible with the Glimmer header #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CvX
reviewed
May 24, 2024
Co-authored-by: Jarek Radosz <[email protected]>
megothss
commented
May 24, 2024
|
|
||
| // adding a small timeout to allow the browser to render all elements, otherwise scrollIntoView's | ||
| // behavior is inconsistent, only working sometimes | ||
| setTimeout(() => { |
There was a problem hiding this comment.
While using the component, I noticed that scrollIntoView was only working sparingly .
I thought it could be because of Ember re-rendering the component, but it doesn't look like it is the case.
Using schedule("afterRender" , ... did not solve the issue.
The only thing that I tried, and it worked, was adding a small delay to allow the browser to render everything.
The solution is not ideal because, frankly, it is unclear to me why it works exactly, but I didn't want to lose too much time with this.
IMO, it is good enough for now.
CvX
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.