Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ensure return types of functions. #767

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ch1booze
Copy link

Fixes #681.

Hi, @sarahdayan, Victor here. I came across the aforementioned issue where you requested explicit return types for functions. I have implemented the necessary changes and added the required types.

Here’s a summary of the updates:

  • Added explicit return types: I explicitly defined return types for all functions as required.
  • Disabled ESLint check in assert.ts: In /dinero.js/packages/core/src/helpers/assert.ts, I disabled the ESLint check for the void return type since it was causing errors.
    Handled undefined scale values: I added default value settings for instances where the ScaledAmount type was initialized with a potentially undefined scale value.

I used VSCode's built-in Refactor feature to generate the return types and manually correct any errors that arose during the process.

Let me know if you need any further adjustments!

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dinerojs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 9:41pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: ensure return type of functions
1 participant