test: Ensure return types of functions. #767
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #681.
Hi, @sarahdayan, Victor here. I came across the aforementioned issue where you requested explicit return types for functions. I have implemented the necessary changes and added the required types.
Here’s a summary of the updates:
assert.ts
: In/dinero.js/packages/core/src/helpers/assert.ts
, I disabled the ESLint check for the void return type since it was causing errors.Handled undefined
scale
values: I added default value settings for instances where the ScaledAmount type was initialized with a potentially undefined scale value.I used VSCode's built-in Refactor feature to generate the return types and manually correct any errors that arose during the process.
Let me know if you need any further adjustments!