Split more things into libraries #7554
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
path-test
branch
2 times, most recently
from
3d9f1b8 to
ff7c974
Compare
glebm
force-pushed
the
path-test
branch
18 times, most recently
from
eed4c8c to
44af477
Compare
glebm
force-pushed
the
path-test
branch
3 times, most recently
from
d96faef to
1f5d04d
Compare
AJenbo
reviewed
Nov 30, 2024
|
This was referenced Dec 29, 2024
glebm
force-pushed
the
path-test
branch
2 times, most recently
from
9ca0170 to
61c6a4a
Compare
This does not fully address the issue of most everything being a giant library but it's a start. I got here by trying to isolate `path.cpp` into its own library and quickly realized that it transitively depends on everything. This is the point where I got to with splitting things up (and gave up for now). This commit also changes the mechanism used to implement transitive dependency support for OBJECT libraries. The new mechanism is more robust but requires to define all OBJECT targets before passing them as dependencies to other targets.
Apparently required for `std::visit`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not fully address the issue of mostly everything being in one giant library but it's a start.
I got here by trying to isolate
path.cppinto its own library and quickly realized that it transitivelydepends on everything.
This is the point where I got to with splitting things up (and gave up for now).
Most of the diff count is from moving SFX enums into a separate file (so that code that only needs the IDs can avoid depending on the entire sound subsystem).
Also changes the mechanism used to implement transitive dependency support for OBJECT
libraries. The new mechanism is more robust but requires that all OBJECT targets are defined before they can be passed as dependencies to other targets.