doc: Update version/CHANGELOG for 0.11.7 #457
clippy ubuntu-latest
14 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 14 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.83.0 (90b35a623 2024-11-26)
- cargo 1.83.0 (5ffbef321 2024-10-29)
- clippy 0.1.83 (90b35a6 2024-11-26)
Annotations
Check warning on line 14 in src/droidplug/mod.rs
github-actions / clippy ubuntu-latest
redundant closure
warning: redundant closure
--> src/droidplug/mod.rs:14:36
|
14 | GLOBAL_ADAPTER.get_or_try_init(|| adapter::Adapter::new())?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `adapter::Adapter::new`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
Check warning on line 722 in src/droidplug/jni/objects.rs
github-actions / clippy ubuntu-latest
using `clone` on type `JObject<'_>` which implements the `Copy` trait
warning: using `clone` on type `JObject<'_>` which implements the `Copy` trait
--> src/droidplug/jni/objects.rs:722:33
|
722 | .is_same_object(services_obj.clone(), JObject::null())?
| ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*services_obj`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Check warning on line 705 in src/droidplug/jni/objects.rs
github-actions / clippy ubuntu-latest
using `clone` on type `JObject<'_>` which implements the `Copy` trait
warning: using `clone` on type `JObject<'_>` which implements the `Copy` trait
--> src/droidplug/jni/objects.rs:705:33
|
705 | .is_same_object(service_data_obj.clone(), JObject::null())?
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*service_data_obj`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Check warning on line 689 in src/droidplug/jni/objects.rs
github-actions / clippy ubuntu-latest
using `clone` on type `JObject<'_>` which implements the `Copy` trait
warning: using `clone` on type `JObject<'_>` which implements the `Copy` trait
--> src/droidplug/jni/objects.rs:689:33
|
689 | .is_same_object(manufacturer_specific_data_obj.clone(), JObject::null())?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*manufacturer_specific_data_obj`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
Check warning on line 649 in src/droidplug/jni/objects.rs
github-actions / clippy ubuntu-latest
using `clone` on type `JObject<'_>` which implements the `Copy` trait
warning: using `clone` on type `JObject<'_>` which implements the `Copy` trait
--> src/droidplug/jni/objects.rs:649:29
|
649 | .is_same_object(record_obj.clone(), JObject::null())?
| ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*record_obj`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
Check warning on line 475 in src/droidplug/jni/objects.rs
github-actions / clippy ubuntu-latest
question mark operator is useless here
warning: question mark operator is useless here
--> src/droidplug/jni/objects.rs:475:9
|
475 | Ok(uuid_obj.as_uuid()?)
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `uuid_obj.as_uuid()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
Check warning on line 398 in src/droidplug/jni/objects.rs
github-actions / clippy ubuntu-latest
question mark operator is useless here
warning: question mark operator is useless here
--> src/droidplug/jni/objects.rs:398:9
|
398 | Ok(uuid_obj.as_uuid()?)
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `uuid_obj.as_uuid()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
Check warning on line 337 in src/droidplug/jni/objects.rs
github-actions / clippy ubuntu-latest
question mark operator is useless here
warning: question mark operator is useless here
--> src/droidplug/jni/objects.rs:337:9
|
337 | Ok(uuid_obj.as_uuid()?)
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing question mark and `Ok()`: `uuid_obj.as_uuid()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
= note: `#[warn(clippy::needless_question_mark)]` on by default
Check warning on line 255 in src/droidplug/peripheral.rs
github-actions / clippy ubuntu-latest
this expression borrows a value the compiler would automatically borrow
warning: this expression borrows a value the compiler would automatically borrow
--> src/droidplug/peripheral.rs:255:9
|
255 | (&guard.services).clone()
| ^^^^^^^^^^^^^^^^^ help: change this to: `guard.services`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 226 in src/droidplug/peripheral.rs
github-actions / clippy ubuntu-latest
this expression borrows a value the compiler would automatically borrow
warning: this expression borrows a value the compiler would automatically borrow
--> src/droidplug/peripheral.rs:226:9
|
226 | (&guard.characteristics).clone()
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `guard.characteristics`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
Check warning on line 221 in src/droidplug/peripheral.rs
github-actions / clippy ubuntu-latest
this expression borrows a value the compiler would automatically borrow
warning: this expression borrows a value the compiler would automatically borrow
--> src/droidplug/peripheral.rs:221:12
|
221 | Ok((&guard.properties).clone())
| ^^^^^^^^^^^^^^^^^^^ help: change this to: `guard.properties`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 14 in src/common/util.rs
github-actions / clippy ubuntu-latest
function `notifications_stream_from_broadcast_receiver` is never used
warning: function `notifications_stream_from_broadcast_receiver` is never used
--> src/common/util.rs:14:8
|
14 | pub fn notifications_stream_from_broadcast_receiver(
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Check warning on line 76 in src/common/adapter_manager.rs
github-actions / clippy ubuntu-latest
method `peripheral_mut` is never used
warning: method `peripheral_mut` is never used
--> src/common/adapter_manager.rs:76:12
|
42 | / impl<PeripheralType> AdapterManager<PeripheralType>
43 | | where
44 | | PeripheralType: Peripheral + 'static,
| |_________________________________________- method in this implementation
...
76 | pub fn peripheral_mut(
| ^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 167 in src/droidplug/peripheral.rs
github-actions / clippy ubuntu-latest
variable does not need to be mutable
warning: variable does not need to be mutable
--> src/droidplug/peripheral.rs:167:44
|
167 | pub(crate) fn report_properties(&self, mut properties: PeripheralProperties) {
| ----^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default