Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(permissions): implicit --allow-import when using --cached-only #27530

Merged
merged 5 commits into from
Jan 2, 2025
Merged

fix(permissions): implicit --allow-import when using --cached-only #27530

merged 5 commits into from
Jan 2, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jan 2, 2025

--cached-only cannot communicate with a remote server

We can't do this for --frozen because --frozen still allows for exfiltrating data.

Closes #27498

nathanwhit
nathanwhit approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsherret dsherret merged commit 2092f0c into denoland:main Jan 2, 2025
17 checks passed
dsherret added a commit that referenced this pull request Jan 2, 2025
@dsherret
fix(permissions): implicit --allow-import when using --cached-only (
2092f0c 
#27530)

`--cached-only` cannot communicate with a remote server

Closes #27498
@dsherret dsherret deleted the fix_implicit_allow_import_with_cached_only_and_frozen branch January 2, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If dependencies are frozen&locked, Deno shouldn't ask permission to import
2 participants
@dsherret @nathanwhit