Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(repl): factor out ReplEditor and ReplSession #13131

Merged
merged 1 commit into from
Dec 18, 2021
Merged

refactor(repl): factor out ReplEditor and ReplSession #13131

merged 1 commit into from
Dec 18, 2021

Conversation

bartlomieju
Copy link
Member

Just a small refactor splitting repl into more modules; this should come in handy in #13122

dsherret
dsherret approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. LGTM

@bartlomieju bartlomieju merged commit 3db18bf into denoland:main Dec 18, 2021
@bartlomieju bartlomieju deleted the repl_sessions branch December 18, 2021 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret