simon/clippy fixes

src/lib.rs

@@ -17,10 +17,20 @@
     clippy::panic_in_result_fn,
     clippy::unwrap_in_result,
     clippy::unwrap_used,
-    // maybe we should use?
     clippy::string_slice,
-    // additional lints
-    clippy::empty_loop
+    clippy::empty_loop,
+    clippy::correctness,
+    clippy::needless_borrow,
+    clippy::cast_lossless,
+    clippy::obfuscated_if_else,
+    clippy::index_refutable_slice,
+    clippy::panic_in_result_fn,
+    clippy::unwrap_in_result,
+    clippy::exit,
+    clippy::todo,
+    clippy::expect_used,
+    clippy::unimplemented,
+    clippy::manual_strip,
 )]
 
 extern crate nom;

src/parser/link_url.rs

@@ -167,7 +167,7 @@ enum UrlInfo<'a> {
     },
 }
 
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub enum LinkParseError<I> {
     Nom(I, ErrorKind),
     ThisIsNotPercentEncoding,
@@ -188,7 +188,7 @@ fn is_reserved(char: char) -> bool {
 }
 
 fn is_hex_digit(c: char) -> bool {
-    c.is_digit(16)
+    c.is_ascii_digit()
 }
 
 fn escaped_char(input: &str) -> IResult<&str, &str, LinkParseError<&str>> {

src/parser/parse_from_text/base_parsers.rs

@@ -8,7 +8,7 @@ use nom::{
     IResult,
 };
 
-#[derive(Debug, PartialEq)]
+#[derive(Debug, PartialEq, Eq)]
 pub enum CustomError<I> {
     NoContent,
     InvalidWhiteSpaceFound,

src/parser/parse_from_text/markdown_elements.rs

@@ -69,7 +69,7 @@ fn code_block(input: &str) -> IResult<&str, Element, CustomError<&str>> {
         Element::CodeBlock {
             language: lang,
             content: content
-                .get(0..content.bytes().count().saturating_sub(offset))
+                .get(0..content.len().saturating_sub(offset))
                 .into_result()?,
         },
     ))