Added JavaScript version for BigInteger and modify the Java version #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2015 12:49
2. Support a return val for illegal input string in decode functions.
|
first off, there's a merge conflict, could you fix that? 2nd, i think it would be better if the JavaScript and Java patches were in 2 separate pull requests |
|
@divinity76 This pull request is old, so the author doesn't have any interest in this anymore, perhaps. But I agree with everything you said. In addition to that, I won't merge the JavaScript changes, anyway, since it introduces a new dependency which is never available in the browser out of the box. The Java solution with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.