use normal error behaviour for failing http requests (fixes #782)

dehydrated-io · Dec 10, 2020 · e784ba3 · e784ba3
1 parent abd369d
commit e784ba3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/dehydrated b/dehydrated
@@ -731,7 +731,9 @@ _sed() {
 
 # Print error message and exit with error
 _exiterr() {
-  echo "ERROR: ${1}" >&2
+  if [ -n "${1:-}" ]; then
+    echo "ERROR: ${1}" >&2
+  fi
   [[ "${skip_exit_hook:-no}" = "no" ]] && [[ -n "${HOOK:-}" ]] && ("${HOOK}" "exit_hook" "${1}" || echo 'exit_hook returned with non-zero exit code!' >&2)
   exit 1
 }
@@ -844,7 +846,7 @@ http_request() {
 
       # remove temporary domains.txt file if used
       [[ "${COMMAND:-}" = "sign_domains" && -n "${PARAM_DOMAIN:-}" && -n "${DOMAINS_TXT:-}" ]] && rm "${DOMAINS_TXT}"
-      exit 1
+      _exiterr
     fi
   fi