Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try pkgconfig befor pkg-config #106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ttamttam
Copy link
Contributor

@ttamttam ttamttam commented Jan 4, 2025

Allows SDL2 detection on my opam + cygwin with mingw system.

tsdl depends on conf-sdl2, which depends on conf-pkg-config, which checks for pkgconfig.

I’m proposing this update of myocamlbuild.ml: it looks for pkgconfig in the PATH and use it if found or else falls-back to the default pkg-config.

Best regards

@dbuenzli
Copy link
Owner

dbuenzli commented Jan 4, 2025

I don't think that's the right place to fix that. If conf-pkg-config is installed I somehow expect that there should be a pkg-config binary.

@ttamttam
Copy link
Contributor Author

ttamttam commented Jan 4, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants