Merge pull request #57 from davidpeach/fix/25-duplicated-local-packag…

…e-requrie

Fix/25 duplicated local package requrie

bin/manuscript-entry

@@ -7,7 +7,7 @@ if (file_exists(__DIR__.'/../../../autoload.php')) {
     require __DIR__.'/../vendor/autoload.php';
 }
 
-$app = new Symfony\Component\Console\Application('Manuscript', '5.0.3');
+$app = new Symfony\Component\Console\Application('Manuscript', '5.0.4');
 $app->add(new DavidPeach\Manuscript\Commands\InitCommand);
 $app->add(new DavidPeach\Manuscript\Commands\CreateCommand);
 $app->add(new DavidPeach\Manuscript\Commands\PlayCommand);

src/ComposerFileManager.php

@@ -33,10 +33,7 @@ public function read(string $pathToFile): array
      */
     public function add(string $pathToFile, array $toAdd): void
     {
-        $composerArray = array_merge_recursive(
-            $this->read(pathToFile: $pathToFile),
-            $toAdd
-        );
+        $composerArray = $this->merge($this->read(pathToFile: $pathToFile), $toAdd);
 
         $composerArray['require'] = (object)$composerArray['require'];
 
@@ -47,4 +44,39 @@ public function add(string $pathToFile, array $toAdd): void
 
         file_put_contents(filename: $pathToFile, data: $updatedComposerJson);
     }
+
+    private function merge($composer, $wantToAdd): array
+    {
+        $okayToAdd = [];
+
+        foreach ($wantToAdd as $key => $additions) {
+
+            if (! array_key_exists(key: $key, array: $composer)) {
+                $okayToAdd[$key] = $additions;
+                continue;
+            }
+
+            $existing = array_map(function ($item) use ($key) {
+                return match ($key) {
+                    'repositories' => $item['url'],
+                    };
+                }, $composer[$key]);
+
+
+            $adding = array_filter($additions, function ($addition) use ($existing, $key) {
+                return match ($key) {
+                    'repositories' => !in_array(needle: $addition['url'], haystack: $existing),
+                };
+            });
+
+            if (! empty($adding)) {
+                $okayToAdd[$key] = $adding;
+            }
+        }
+
+        return array_merge_recursive(
+            $composer,
+            $okayToAdd
+        );
+    }
 }

tests/Unit/ComposerFileManagerTest.php

@@ -0,0 +1,58 @@
+<?php
+
+namespace DavidPeach\Manuscript\Tests\Unit;
+
+use DavidPeach\Manuscript\ComposerFileManager;
+use DavidPeach\Manuscript\Playgrounds;
+use DavidPeach\Manuscript\Tests\TestCase;
+use Symfony\Component\Filesystem\Filesystem;
+use Symfony\Component\Finder\Finder;
+
+class ComposerFileManagerTest extends TestCase
+{
+    private string $root;
+
+    private Filesystem $fs;
+
+    /**
+     * Clear out the "tests/test-environments" directory before each new test
+     */
+    public function setUp(): void
+    {
+        $this->root = realpath(__DIR__ . '/../test-environments/composer-file-manager');
+
+        file_put_contents(
+            $this->root . '/composer.json',
+            file_get_contents(__DIR__ . '/../test-environments/stubs/composer.json')
+        );
+
+        $this->fs = new Filesystem;
+
+        parent::setUp();
+    }
+
+    /** @test */
+    public function packages_cannot_be_added_to_a_composer_require_multiple_times()
+    {
+        $composer = new ComposerFileManager();
+
+        $composer->add(
+            pathToFile: $this->root . '/composer.json',
+            toAdd: ['repositories' => [
+                [
+                    'type' => 'path',
+                    'url'  =>  '/some/local/path',
+                    'options' => [
+                        'symlink' => true,
+                    ],
+                ]
+            ]]
+        );
+
+        $composerFileData = $composer->read($this->root . '/composer.json');
+
+        $this->assertCount(1, $composerFileData['repositories']);
+
+        $this->fs->remove($this->root . '/composer.json');
+    }
+}

tests/test-environments/stubs/composer.json

@@ -10,5 +10,12 @@
       "name": "David Peach",
       "email": "[email protected]"
     }
-  ]
+  ],
+  "repositories": [{
+    "type": "path",
+    "url": "/some/local/path",
+    "options": {
+      "symlink": true
+    }
+  }]
 }