Add 'experimental/python' support #2052
Conversation
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| @@ -441,9 +547,9 @@ func createInitOverrideVisitor(ctx context.Context) merge.OverrideVisitor { | |||
| } | |||
|
|
|||
| func isOmitemptyDelete(left dyn.Value) bool { | |||
| // PyDABs can omit empty sequences/mappings in output, because we don't track them as optional, | |||
| // Python can omit empty sequences/mappings in output, because we don't track them as optional, | |||
There was a problem hiding this comment.
I find the original sentence more clear, "Python can omit empty sequences/mappings in output" does not make sense, as I assume Python is CPython binary.
There was a problem hiding this comment.
👍 We are getting rid of "PyDABs" name, so we can't use it anymore. I've rephrased it the same way as it was in the unit test.
kanterov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| "pattern": "\\$\\{(var(\\.[a-zA-Z]+([-_]?[a-zA-Z0-9]+)*(\\[[0-9]+\\])*)+)\\}" | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Please execute "make schema" to update this.
## Changes I noticed a diff in the schema in #2052. This check should be performed automatically. ## Tests This PR includes a commit that changes the schema to check that the workflow actually fails.
kanterov
force-pushed
the
kanterov/new-python-support
branch
from
673b7fd to
29d5da2
Compare
| @@ -137,7 +225,7 @@ func createCacheDir(ctx context.Context) (string, error) { | |||
| // support the same env variable as in b.CacheDir | |||
| if tempDir, exists := env.TempDir(ctx); exists { | |||
| // use 'default' as target name | |||
| cacheDir := filepath.Join(tempDir, "default", "pydabs") | |||
| cacheDir := filepath.Join(tempDir, "default", "python") | |||
There was a problem hiding this comment.
For later:
// b.CacheDir doesn't work because target isn't yet selected
This no longer holds in the new world and can be cleaned up.
| case PythonMutatorPhaseLoadResources: | ||
| return createLoadResourcesOverrideVisitor(ctx), nil | ||
| case PythonMutatorPhaseApplyMutators: | ||
| return createInitOverrideVisitor(ctx, insertResourceModeDisallow), nil |
There was a problem hiding this comment.
For later: include comments how the first 2 apply to the deprecated mode and the last 2 to the new mode.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
An issue with the linter prevents the merge. @kanterov I'm updating the PR to let it merge. |
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Changes
Add
experimental/pythonsection replacingexperimental/pydabs.Add 2 new mutators into existing pipeline:
ApplyPythonMutator(load_resources)- loads resources from Python codeApplyPythonMutator(apply_mutators)- transforms existing resources defined in Python/YAMLExample:
Tests
Unit tests and manually