Skip to content

Commit

Permalink
Merge pull request #9 from danger/050
Browse files Browse the repository at this point in the history
Updates Danger dependency to 4.x
  • Loading branch information
orta authored Feb 10, 2017
2 parents 4be5267 + 12bb0f7 commit 883a539
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 29 deletions.
39 changes: 17 additions & 22 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
PATH
remote: .
specs:
danger-mention (0.4.0)
danger-mention (0.5.0)
danger (>= 2.0.0)

GEM
remote: https://rubygems.org/
specs:
addressable (2.4.0)
addressable (2.5.0)
public_suffix (~> 2.0, >= 2.0.2)
ast (2.3.0)
claide (1.0.1)
claide-plugins (0.9.2)
Expand All @@ -16,31 +17,28 @@ GEM
open4 (~> 1.3)
coderay (1.1.1)
colored (1.2)
colored2 (3.1.1)
cork (0.2.0)
colored (~> 1.2)
danger (3.5.5)
danger (4.2.1)
claide (~> 1.0)
claide-plugins (>= 0.9.2)
colored (~> 1.2)
colored2 (~> 3.1)
cork (~> 0.1)
faraday (~> 0.9)
faraday-http-cache (~> 1.0)
git (~> 1)
gitlab (~> 3.7.0)
kramdown (~> 1.5)
octokit (~> 4.2)
terminal-table (~> 1)
diff-lcs (1.2.5)
faraday (0.9.2)
faraday (0.11.0)
multipart-post (>= 1.2, < 3)
faraday-http-cache (1.3.1)
faraday (~> 0.8)
ffi (1.9.14)
formatador (0.2.5)
git (1.3.0)
gitlab (3.7.0)
httparty (~> 0.13.0)
terminal-table
guard (2.14.0)
formatador (>= 0.2.4)
listen (>= 2.7, < 4.0)
Expand All @@ -55,25 +53,20 @@ GEM
guard (~> 2.1)
guard-compat (~> 1.1)
rspec (>= 2.99.0, < 4.0)
httparty (0.13.7)
json (~> 1.8)
multi_xml (>= 0.5.2)
json (1.8.3)
kramdown (1.12.0)
kramdown (1.13.2)
listen (3.0.7)
rb-fsevent (>= 0.9.3)
rb-inotify (>= 0.9.7)
lumberjack (1.0.10)
method_source (0.8.2)
multi_xml (0.5.5)
multipart-post (2.0.0)
nap (1.1.0)
nenv (0.3.0)
notiffany (0.1.1)
nenv (~> 0.1)
shellany (~> 0.0)
octokit (4.3.0)
sawyer (~> 0.7.0, >= 0.5.3)
octokit (4.6.2)
sawyer (~> 0.8.0, >= 0.5.3)
open4 (1.3.4)
parser (2.3.1.2)
ast (~> 2.2)
Expand All @@ -82,6 +75,7 @@ GEM
coderay (~> 1.1.0)
method_source (~> 0.8.1)
slop (~> 3.4)
public_suffix (2.0.5)
rainbow (2.1.0)
rake (10.5.0)
rb-fsevent (0.9.7)
Expand All @@ -107,12 +101,13 @@ GEM
ruby-progressbar (~> 1.7)
unicode-display_width (~> 1.0, >= 1.0.1)
ruby-progressbar (1.8.1)
sawyer (0.7.0)
addressable (>= 2.3.5, < 2.5)
faraday (~> 0.8, < 0.10)
sawyer (0.8.1)
addressable (>= 2.3.5, < 2.6)
faraday (~> 0.8, < 1.0)
shellany (0.0.1)
slop (3.6.0)
terminal-table (1.6.0)
terminal-table (1.7.0)
unicode-display_width (~> 1.1)
thor (0.19.1)
unicode-display_width (1.1.0)
yard (0.9.5)
Expand All @@ -131,4 +126,4 @@ DEPENDENCIES
yard (~> 0.8)

BUNDLED WITH
1.13.1
1.13.6
23 changes: 18 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,24 @@ The easiest way to use is just add this to your Dangerfile:
mention.run
```

Additionally you can set up maximum number of people to ping in the PR message, regexes of ignored files and list of users that will never be mentioned.

```rb
mention.run(2, ["Pods/"], ["wojteklu"])
```
<blockquote>Running plugin with reviewers count specified
<pre>
# Find maximum two reviewers
mention.run(2, [], [])</pre>
</blockquote>

<blockquote>Running plugin with some files blacklisted
<pre>
# Find reviewers without parsing blame information
# from files matching to 'Pods/*'
mention.run(2, ["Pods/*"], [])</pre>
</blockquote>

<blockquote>Running plugin with some users blacklisted
<pre>
# Find reviewers ignoring users 'wojteklu' and 'danger'
mention.run(2, [], ["wojteklu", "danger"])</pre>
</blockquote>

## License

Expand Down
2 changes: 1 addition & 1 deletion lib/version.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
module DangerMention
VERSION = '0.4.0'.freeze
VERSION = '0.5.0'.freeze
DESCRIPTION = 'Danger plugin to automatically mention potential reviewers on pull requests'
end
2 changes: 1 addition & 1 deletion spec/danger_plugin_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ module Danger

it 'mentions potential reviewers' do
@mention.run
output = @mention.status_report[:markdowns].first
output = @mention.status_report[:markdowns].first.message

expect(output).to_not be_empty
expect(output).to include('@user1')
Expand Down

0 comments on commit 883a539

Please sign in to comment.