Clear missing DSL timeout to allow danger runner to exit when done #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setTimeout for missing DSL will cause nodeCleanup to wait for it to timeout before exiting even if the DSL was found
normano64
changed the title
|
This makes sense to me 👍🏻 - great find |
glensc
reviewed
Jan 26, 2024
| if (!foundDSL) { | ||
| console.error(chalk.red("Timeout: Failed to get the Danger DSL after 1 second")) | ||
| console.error(chalk.red("Timeout: Failed to get the Danger DSL after 10 second")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the danger step in CI was always taking more than 10 seconds, the root cause was that nodeCleanup was waiting for the missing DSL timeout before continuing even when the DSL was found