Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gdpr compliance #4070

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

feat: gdpr compliance #4070

wants to merge 37 commits into from

Conversation

sshanzel
Copy link
Member

@sshanzel sshanzel commented Jan 15, 2025

Changes

  • Update our Cookie Banner into two categories:
    • EU: allow users to update the cookie preference on a granular level.
    • Non EU: use the same updated cookie banner (delete the old one), but should only have one button labeled "I understand".
  • Pixel tracking should be delayed being rendered for EU users until marketing is accepted.
  • Introduce a placeholder for the YT contents to not render the integration, which registers a cookie, when not accepted. Again, for EU users.
  • Even though we are storing the information in the browser cookie, I also had to use the local storage in order to know if the user have made past decisions about the preferences.
    • This is because our default value is true, but then we also need to check whether made any past decision already, which is the local storage in itself.
  • You might notice some things were built in a reusable way which was not necessary in hindsight. We had some late decisions that led to using just one, so I just deleted the other parts that used those reusable blocks.

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

MI-736 #done

Preview domain

https://mi-736.preview.app.daily.dev

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Jan 17, 2025 2:14pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Jan 17, 2025 2:14pm

@sshanzel
Copy link
Member Author

I also got the customize flow, but not in EU should it have happened?

That was due to the dev mode. You should not get it anymore, but have the same banner with a single button.

Learn more about our Cookie Policy → (Probably should open target_blank?

Yeah, I think so too. Have updated now.

This one looks like I can turn it off, but I can't its super weird UX..

It should not be possible to be turned off. From Figma it should be disabled. Applied the disabled prop now.

Also reject all still accepts the one right?

Yes, the necessary one.

Comment on lines +13 to +16
export const getCookies = <
T extends string[] = string[],
R = Record<T[number], string>,
>(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just improved the typings so that the returned object would contain the right keys from the type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants