-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gdpr compliance #4070
base: main
Are you sure you want to change the base?
feat: gdpr compliance #4070
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
That was due to the dev mode. You should not get it anymore, but have the same banner with a single button.
Yeah, I think so too. Have updated now.
It should not be possible to be turned off. From Figma it should be disabled. Applied the disabled prop now.
Yes, the necessary one. |
Co-authored-by: Ole-Martin Bratteng <[email protected]>
export const getCookies = < | ||
T extends string[] = string[], | ||
R = Record<T[number], string>, | ||
>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just improved the typings so that the returned object would contain the right keys from the type.
Changes
true
, but then we also need to check whether made any past decision already, which is the local storage in itself.Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
MI-736 #done
Preview domain
https://mi-736.preview.app.daily.dev