-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump supported kubernetes from 1.29 to 1.30 #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
staticcheck fails due to a different version of go.
setup-go uses the go directive in go.mod as the go version.
https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file
actions/setup-go#457
Can you use staticcheck included in cybozu/golang image?
https://github.com/cybozu/neco-containers/blob/3582b8aa8e62a8f8f2a3913c5aa4d8ede78abe89/golang-all/golang-1.23-jammy/Dockerfile#L19
We concluded that it's better to modify the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
k8s versions are a bit older, but matches with https://github.com/cybozu-go/meows.