Document that only the last value of --output is used, add test for it #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiodj
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Thanks, @samueloph.
There's just a very small nit, but otherwise LGTM. +1
tests/tests.sh
Outdated
| testOutputFileNameRepeatedOption() | ||
| { | ||
| url='example.com' | ||
| ret=$(${WCURL_CMD} -o "test filename" -o "test filename2" ${url} 2>&1) |
There was a problem hiding this comment.
Suggested change
| ret=$(${WCURL_CMD} -o "test filename" -o "test filename2" ${url} 2>&1) | |
| ret=$(${WCURL_CMD} -o "test filename" -o "test filename2" ${url} 2>&1) |
| @@ -76,7 +76,8 @@ Specify extra options to be passed when invoking curl. May be specified more tha | |||
| \fB\-o, \-O, \-\-output=\fI<PATH>\fR...\fR | |||
| Use the provided output path instead of getting it from the URL. If multiple | |||
| URLs are provided, all files will have the same name with a number appended to | |||
| the end (curl >= 7.83.0). | |||
| the end (curl >= 7.83.0). If this option is provided multiple times, only the | |||
| last value is considered. | |||
There was a problem hiding this comment.
Just a thought here: we now have to repeat these texts 3 times at least. It'd be great to have some kind of templating system.
Either way, I believe we can address this problem later, when we rewrite wcurl.
samueloph
force-pushed
the
samueloph/output_docs
branch
from
56c2f01 to
75a9254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.