Init CHANGELOG.md #33

samueloph · 2024-12-07T19:42:34Z

No description provided.

sergiodj

I left some comments and requests for change, but the file is looking good.

sergiodj · 2024-12-07T23:33:58Z

CHANGELOG.md

+ * First release to be shipped on Debian.
+
+## [v2024-06-26]
+ * Second release.


Not that it matters much, but would you like to add some information on what changed here?

sergiodj · 2024-12-07T23:36:08Z

CHANGELOG.md

+ * Update LICENSE file with new contributors.
+
+## [v2024-07-07]
+ * Drop getotp usage, non-linux environments are supported now.


s/getotp/getopt/

Use backticks on getopt.

I will personally use "GNU/Linux", but it's OK if you don't want to. However, I believe we should at least capitalize the name "Linux" here.

sergiodj · 2024-12-07T23:36:43Z

CHANGELOG.md

+
+## [v2024-07-07]
+ * Drop getotp usage, non-linux environments are supported now.
+ * Replace "-o/--opts=" parameters with "--curl-options/--curl-options=".


Since this file is explicitly written in Markdown, we should use backticks here and elsewhere.

sergiodj · 2024-12-07T23:38:09Z

CHANGELOG.md

+   This alternative is more descriptive and it does not coincide with any of curl's parameters.
+ * Stop auto-resuming downloads and don't overwrite files instead by default.
+   Safer alternative as otherwise curl can corrupt a file if the name clashes and the size of the existing one is smaller.
+   One can easily change that behavior with '--curl-options="--continue-at -'.


There's a mix of single and double quotes here (but we should use backticks).

sergiodj · 2024-12-07T23:38:30Z

CHANGELOG.md

+   Safer alternative as otherwise curl can corrupt a file if the name clashes and the size of the existing one is smaller.
+   One can easily change that behavior with '--curl-options="--continue-at -'.
+ * New --dry-run option: just print what would be invoked.
+ * Choose https as a default protocol, in case there's none in the URL.


s/https/HTTPS/.

sergiodj · 2024-12-07T23:39:17Z

CHANGELOG.md

+ * Choose https as a default protocol, in case there's none in the URL.
+ * Disable curl's URL globbing parser so {} and [] characters in URLs are not treated specially.
+ * Implement support for '--'.
+ * Implement a -V and --version options.


Suggested change

* Implement a -V and --version options.

* Implement `-V/--version` options.

sergiodj · 2024-12-07T23:40:46Z

CHANGELOG.md

+     - New version: 2024.07.10
+ * Support older curl releases, minimum required version is now 7.46.0:
+     - Only set --no-clobber if curl is 7.83 or newer
+     - Only set --parallel if curl is 7.66 or newer


Missing period at the end of this sentence and the previous one.

sergiodj · 2024-12-07T23:41:44Z

CHANGELOG.md

+ * Support older curl releases, minimum required version is now 7.46.0:
+     - Only set --no-clobber if curl is 7.83 or newer
+     - Only set --parallel if curl is 7.66 or newer
+ * Set --fail on curl, in order to return errors instead of saving as


Suggested change

* Set --fail on curl, in order to return errors instead of saving as

* Set `--fail` when invoking curl, in order to display possible errors instead of saving them as

sergiodj · 2024-12-07T23:42:34Z

CHANGELOG.md

+   output files.
+ * Add more tests.
+ * Remove the need for GNU coreutils' realpath for tests.
+ * wcurl.1: Update manpage with links to Github and Debian's Salsa.


This format of file: what changed isn't used anywhere else, so I think we shouldn't use it here either.

sergiodj · 2024-12-07T23:43:17Z

CHANGELOG.md

+# Changelog
+
+## [UNRELEASED]
+ * Default to index.html as filename if non can be parsed from the URL.


I think there's some typo here...? I don't fully understand the sentence.

samueloph · 2024-12-08T18:59:03Z

Thanks, @samueloph.

I left some comments and requests for change, but the file is looking good.

Thank you @sergiodj, I believe I have addressed all of them with the latest changes.

sergiodj

Thanks, @samueloph.

I'm leaving a second round of suggestions that are ready to be applied. Feel free to merge the PR afterwards.

sergiodj · 2024-12-08T22:02:15Z

CHANGELOG.md

+
+## [UNRELEASED]
+ * New parameter `-o|-O|--output|output=` which allows the user to choose the output filename.
+ * Default to "index.html" as filename if none can be inferred from the URL.


Suggested change

* Default to "index.html" as filename if none can be inferred from the URL.

* Default to `index.html` as filename if none can be inferred from the URL.

sergiodj · 2024-12-08T22:03:15Z

CHANGELOG.md

+     - Previous version: 2024-07-07
+     - New version: 2024.07.10


Suggested change

- Previous version: 2024-07-07

- New version: 2024.07.10

- Previous version: `2024-07-07`

- New version: `2024.07.10`

sergiodj · 2024-12-08T22:03:45Z

CHANGELOG.md

+ * Set `--fail` when invoking curl, in order to display possible errors instead of saving them as
+   output files.
+ * Add more tests.
+ * Remove the need for GNU coreutils' realpath for tests.


Suggested change

* Remove the need for GNU coreutils' realpath for tests.

* Remove the need for GNU coreutils' `realpath` for tests.

sergiodj · 2024-12-08T22:04:29Z

CHANGELOG.md

+ * New `--dry-run` option: just print what would be invoked.
+ * Choose HTTPS as a default protocol, in case there's none in the URL.
+ * Disable curl's URL globbing parser so `{}` and `[]` characters in URLs are not treated specially.
+ * Implement support for `--`'.


Suggested change

* Implement support for `--`'.

* Implement support for `--`.

sergiodj · 2024-12-08T22:04:57Z

CHANGELOG.md

+ * Only set `--parallel` if there's more than one URL.
+ * Fix manpage typo.
+ * Update COPYRIGHT and AUTHORS in manpage.
+ * Rewrite wcurl to remove bash dependency, it's now a POSIX shellscript.


Suggested change

* Rewrite wcurl to remove bash dependency, it's now a POSIX shellscript.

* Rewrite wcurl to remove bash dependency, it's now a POSIX shell script.

sergiodj · 2024-12-08T22:05:11Z

CHANGELOG.md

+ * Add LICENSE.
+
+## [v2024-06-26]
+ * Simplify`--help` output.


Suggested change

* Simplify`--help` output.

* Simplify `--help` output.

sergiodj · 2024-12-08T22:05:38Z

CHANGELOG.md

+
+## [v2024-07-07]
+ * Drop `getopt` usage, non-GNU/Linux environments are supported now.
+ * Replace `-o/--opts=` parameters with `--curl-options/--curl-options=`.


Suggested change

* Replace `-o/--opts=` parameters with `--curl-options/--curl-options=`.

* Replace `-o`/`--opts=` parameters with `--curl-options`/`--curl-options=`.

sergiodj · 2024-12-08T22:05:55Z

CHANGELOG.md

+ * Choose HTTPS as a default protocol, in case there's none in the URL.
+ * Disable curl's URL globbing parser so `{}` and `[]` characters in URLs are not treated specially.
+ * Implement support for `--`'.
+ * Implement `-V/--version` options.


Suggested change

* Implement `-V/--version` options.

* Implement `-V`/`--version` options.

samueloph force-pushed the samueloph/CHANGELOG.md branch 2 times, most recently from 8abdf10 to 8821818 Compare December 7, 2024 19:45

sergiodj requested changes Dec 7, 2024

View reviewed changes

samueloph force-pushed the samueloph/CHANGELOG.md branch from 8821818 to 4a68168 Compare December 8, 2024 18:54

samueloph requested a review from sergiodj December 8, 2024 19:07

sergiodj requested changes Dec 8, 2024

View reviewed changes

samueloph force-pushed the samueloph/CHANGELOG.md branch from 4a68168 to 09be7a5 Compare December 8, 2024 22:21

samueloph requested a review from sergiodj December 8, 2024 22:31

Init CHANGELOG.md

b653a92

samueloph force-pushed the samueloph/CHANGELOG.md branch from 09be7a5 to b653a92 Compare December 8, 2024 22:54

samueloph merged commit 340ac12 into main Dec 8, 2024
1 check passed

samueloph deleted the samueloph/CHANGELOG.md branch December 8, 2024 22:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Init CHANGELOG.md #33

Init CHANGELOG.md #33

samueloph commented Dec 7, 2024

sergiodj left a comment

sergiodj Dec 7, 2024

sergiodj Dec 7, 2024

sergiodj Dec 7, 2024

sergiodj Dec 7, 2024

sergiodj Dec 7, 2024

sergiodj Dec 7, 2024

sergiodj Dec 7, 2024

sergiodj Dec 7, 2024

sergiodj Dec 7, 2024

sergiodj Dec 7, 2024

samueloph commented Dec 8, 2024

sergiodj left a comment

sergiodj Dec 8, 2024

sergiodj Dec 8, 2024

sergiodj Dec 8, 2024

sergiodj Dec 8, 2024

sergiodj Dec 8, 2024

sergiodj Dec 8, 2024

sergiodj Dec 8, 2024

sergiodj Dec 8, 2024

	* Implement a -V and --version options.
	* Implement `-V/--version` options.

	* Set --fail on curl, in order to return errors instead of saving as
	* Set `--fail` when invoking curl, in order to display possible errors instead of saving them as

	* Default to "index.html" as filename if none can be inferred from the URL.
	* Default to `index.html` as filename if none can be inferred from the URL.

	* Remove the need for GNU coreutils' realpath for tests.
	* Remove the need for GNU coreutils' `realpath` for tests.

	* Rewrite wcurl to remove bash dependency, it's now a POSIX shellscript.
	* Rewrite wcurl to remove bash dependency, it's now a POSIX shell script.

	* Replace `-o/--opts=` parameters with `--curl-options/--curl-options=`.
	* Replace `-o`/`--opts=` parameters with `--curl-options`/`--curl-options=`.

	* Implement `-V/--version` options.
	* Implement `-V`/`--version` options.

Init CHANGELOG.md #33

Init CHANGELOG.md #33

Conversation

samueloph commented Dec 7, 2024

sergiodj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samueloph commented Dec 8, 2024

sergiodj left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment