Add shellcheck to project and fix warnings #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Diniz <[email protected]>
arthurbdiniz
force-pushed
the
shellcheck
branch
from
7b77ae3 to
6144923
Compare
|
Move changes from this PR to #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request integrates
shellcheckinto the project and fixes existing warnings to improve script quality.Details
shellcheckas a dependency to lint the shell scripts, ensuring they follow best practices and are free of issues.README.mdto include instructions on how to installshellcheckand run it on the project’s shell scripts.tests/tests.shscript to correct any warnings reported byshellcheckInstructions for Testing
Install shellcheck:
apt-get install shellcheckdnf install shellcheckRun
shellcheckon wcurl and tests: