Makefile: fix LDFLAGS order; and don't force -Werror #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix order of LDFLAGS, as mentioned in curl#158, this is necessary for e.g. `-Wl,--as-needed` to work correctly. -Werror is now only added in non-NDEBUG builds. Ref: gentoo/gentoo#38168
emanuele6
added a commit
to emanuele6/the-gentoo
that referenced
this pull request
Aug 16, 2024
The old Makefile patch can no longer be applied, and is no longer necessary since version 0.8; so I wrote a new patch that applies to 0.14 that is also applied to the 9999 version for now, and sent it upstream. I also fixed the old patch that was incorrectly passing CPPFLAGS and CFLAGS to the linker. Additionally, I added an export NDEBUG=1 command in src_compile: without this, -g and -Werror are added after CFLAGS by the Makefile possibly shadowing options like -ggdb3 that user might have set, or causing a build to fail just because a warning was reported. Bump copyright of touched ebuild files. Ref: curl/trurl@75fec313d9 Ref: curl/trurl#322 Signed-off-by: Emanuele Torre <[email protected]>
emanuele6
added a commit
to emanuele6/the-gentoo
that referenced
this pull request
Aug 16, 2024
The old Makefile patch can no longer be applied, and is no longer necessary since version 0.8; so I wrote a new patch that applies to 0.14 that is also applied to the 9999 version for now, and sent it upstream. I also fixed the old patch that was incorrectly passing CPPFLAGS and CFLAGS to the linker, and not passing -Wall to the compiler. Additionally, I added an export NDEBUG=1 command in src_compile: without this, -g and -Werror are added after CFLAGS by the Makefile possibly shadowing options like -ggdb3 that user might have set, or causing a build to fail just because a warning was reported. Bump copyright of touched ebuild files. Ref: curl/trurl@75fec313d9 Ref: curl/trurl#322 Signed-off-by: Emanuele Torre <[email protected]>
emanuele6
added a commit
to emanuele6/the-gentoo
that referenced
this pull request
Aug 16, 2024
The old Makefile patch can no longer be applied, and is no longer necessary since version 0.8; so I wrote a new patch that applies to 0.14 that is also applied to the 9999 version for now, and sent it upstream. Additionally, I added an export NDEBUG=1 command in src_compile: without this, -g and -Werror are added after CFLAGS by the Makefile possibly shadowing options like -ggdb3 that user might have set, or causing a build to fail just because a warning was reported. Bump copyright of touched ebuild files. Ref: curl/trurl@75fec313d9 Ref: curl/trurl#322 Signed-off-by: Emanuele Torre <[email protected]>
emanuele6
added a commit
to emanuele6/the-gentoo
that referenced
this pull request
Aug 16, 2024
The old Makefile patch can no longer be applied; so I wrote a new patch that applies to 0.14 that is also applied to the 9999 version for now, and sent it upstream. Additionally, I added an export NDEBUG=1 command in src_compile: without this, -g and -Werror are added after CFLAGS by the Makefile possibly shadowing options like -ggdb3 that user might have set, or causing a build to fail just because a warning was reported. Bump copyright of touched ebuild files. Ref: curl/trurl#322 Signed-off-by: Emanuele Torre <[email protected]>
emanuele6
added a commit
to emanuele6/the-gentoo
that referenced
this pull request
Aug 16, 2024
The old Makefile patch can no longer be applied; so I wrote a new patch that applies to 0.14 that is also applied to the 9999 version for now, and sent it upstream. Additionally, I added an export NDEBUG=1 command in src_compile: without this, -g and -Werror are added after CFLAGS by the Makefile possibly shadowing options like -ggdb3 that user might have set, or causing a build to fail just because a warning was reported. Bump copyright of touched ebuild files. Ref: curl/trurl#322 Signed-off-by: Emanuele Torre <[email protected]>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Aug 16, 2024
The old Makefile patch can no longer be applied; so I wrote a new patch that applies to 0.14 that is also applied to the 9999 version for now, and sent it upstream. Additionally, I added an export NDEBUG=1 command in src_compile: without this, -g and -Werror are added after CFLAGS by the Makefile possibly shadowing options like -ggdb3 that user might have set, or causing a build to fail just because a warning was reported. Bump copyright of touched ebuild files. Ref: curl/trurl#322 Signed-off-by: Emanuele Torre <[email protected]> Signed-off-by: Sam James <[email protected]>
bagder
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix order of LDFLAGS, as mentioned in #158, this is necessary for e.g.
-Wl,--as-neededto work correctly.-Werroris now only added in non-NDEBUG builds.Ref: gentoo/gentoo#38168