trurl: support compiling with old versions of Visual Studio #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define bool type and remove mixed declarations for old versions of Visual Studio. This supports compiling trurl with old versions of Visual Studio by using cl at the command line only. The winbuild solution still requires recent versions of Visual Studio. Closes #xxxx
vszakats
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports compiling trurl with old versions of Visual Studio by using cl at the command line only. The winbuild solution still requires recent versions of Visual Studio.
Closes #xxxx
These are some changes to build trurl with an old Visual Studio compiler which uses C89. I tested it with Visual Studio 2010.
libcurl was built using configuration
LIB Debug - DLL Windows SSPI - DLL WinIDNin the pregenerated solution..\curl\projects\Windows\VC10\curl-all.sln, and then trurl was built against it:cl /MDd /W4 /wd4127 /D_CRT_SECURE_NO_WARNINGS /D_UNICODE /DUNICODE /DCURL_STATICLIB /I..\curl\include trurl.c /link /LIBPATH:"..\curl\build\Win32\VC10\LIB Debug - DLL Windows SSPI - DLL WinIDN" libcurld.lib crypt32.lib normaliz.lib wldap32.lib ws2_32.libTo support other c89 compilers would probably require a stdint replacement.