-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build libcurl without http #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
win-smaller-exe
branch
from
November 16, 2023 17:23
ef7f016
to
864e157
Compare
There are reasonable savings in binary size by using a slimmed down libcurl. The downside is the loss of the It'd help if trurl could provide its own list of default ports without relying on libcurl |
Agreed! It is probably best handled by trurl itself... |
vszakats
force-pushed
the
win-smaller-exe
branch
2 times, most recently
from
November 17, 2023 13:47
562ac28
to
46083e2
Compare
vszakats
changed the title
ci: build libcurl without http
ci: build libcurl without http and imap
Nov 17, 2023
vszakats
added a commit
to vszakats/trurl
that referenced
this pull request
Nov 17, 2023
Also move http/80 tests to imap/143 for default-port tests. To allow thinner libcurl builds without HTTP support. We need IMAP already for IMAP options support. Also mark tests relying on IMAP default port to require libcurl with IMAP enabled. ARM64 `trurl.exe` sizes: - Before: 465KB https://github.com/curl/trurl/actions/runs/6903445608 - After, no http: 318KB https://github.com/curl/trurl/actions/runs/6903509264 - no http, no unity: 244KB https://github.com/curl/trurl/actions/runs/6903576741 - no http, no unity, no imap: 189KB https://github.com/curl/trurl/actions/runs/6903738976 Closes curl#255
vszakats
force-pushed
the
win-smaller-exe
branch
from
November 17, 2023 15:17
7f3cb3e
to
b7b6ab3
Compare
vszakats
changed the title
ci: build libcurl without http and imap
ci: build libcurl without http
Nov 17, 2023
vszakats
added a commit
to vszakats/trurl
that referenced
this pull request
Nov 17, 2023
For even smaller trurl binaries, and faster builds with libcurl built without http support. Also move http/80 tests to imap/143 for default-port tests. We need IMAP already for IMAP options support. Also mark tests relying on IMAP default port to require libcurl with IMAP enabled. ARM64 `trurl.exe` sizes: Before: 465KB https://github.com/curl/trurl/actions/runs/6903445608 After, no http: 324KB https://github.com/curl/trurl/actions/runs/6903509264 no http, no unity: 245KB https://github.com/curl/trurl/actions/runs/6903576741 no http, no unity, no imap: 189KB https://github.com/curl/trurl/actions/runs/6903738976 Closes curl#255
vszakats
force-pushed
the
win-smaller-exe
branch
from
November 17, 2023 16:21
b7b6ab3
to
84938d3
Compare
For even smaller trurl binaries, and faster builds with libcurl built without http support. Also move http/80 tests to imap/143 for default-port tests. We need IMAP already for IMAP options support. Also mark tests relying on IMAP default port to require libcurl with IMAP enabled. ARM64 `trurl.exe` sizes: - Before: 465KB https://github.com/curl/trurl/actions/runs/6903445608 - After, no http: 324KB https://github.com/curl/trurl/actions/runs/6903509264 - no http, no unity: 245KB https://github.com/curl/trurl/actions/runs/6903576741 - no http, no imap, unity: 243KB https://github.com/curl/trurl/actions/runs/6906597033 - no http, no imap, no unity: 189KB https://github.com/curl/trurl/actions/runs/6903738976 Closes curl#255
vszakats
force-pushed
the
win-smaller-exe
branch
from
November 17, 2023 16:40
29a3f3e
to
f7c7f54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For even smaller trurl binaries, and faster builds with libcurl built
without http support.
Also move http/80 tests to imap/143 for default-port tests.
We need IMAP already for IMAP options support.
Also mark tests relying on IMAP default port to require libcurl with
IMAP enabled.
ARM64
trurl.exe
sizes:Closes #255
Pending: curl/curl#12343 [MERGED]