Makefile: updates and fixes #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `TRURL_IGNORE_CURL_CONFIG` to avoid reading `curl-config`. This allows to specify curl bits manually without unexpectedly picking up system curl bits too. - allow to disable debug info by passing `NDEBUG=1`. - drop `-std=gnu99` from `CFLAGS`. This decision should be up to the builder, in sync with the curl (and its dependencies) linked to trurl. curl doesn't build with this option by default and mixing objects with different settings may break the ABI. - accept `LDLIBS` from the environment. - one whitespace tidy-up. Closes #xxx
bagder
approved these changes
Nov 9, 2023
|
Thanks! |
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
TRURL_IGNORE_CURL_CONFIGoption to avoid readingcurl-config. This allows to specify curl bits manually withoutunexpectedly picking up system curl bits.
allow to disable debug info by passing
NDEBUG=1.drop
-std=gnu99fromCFLAGS. This decision should be up to thebuilder, in sync with the curl (and its dependencies) linked to trurl.
curl doesn't build with this option by default and mixing objects with
different settings may break the ABI.
accept
LDLIBSfrom the environment.one whitespace tidy-up.
Closes #248