Trurl_errorf #235
Closed
Trurl_errorf #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
reviewed
Oct 27, 2023
jacobmealey
force-pushed
the
trurl_errof
branch
from
8bccffb to
844bdd2
Compare
|
hm okay, merging from master made a few new memory leaks. I will try and resolve them over the next few days. |
|
Can you take a look at the merge conflict as well? |
jacobmealey
force-pushed
the
trurl_errof
branch
from
acc32df to
0465edd
Compare
|
Okay, this should be all set to merge now. |
bagder
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added trurl_errorf which handles cleanup of
struct optionbefore exiting but after printing in case whats being printed must be cleaned up. It is based on #234 so that should be merged before this. Note that this (should) fix the two memory leaks discussed in #232 that were left over.