Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/security: show the severity filter status #305

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Oct 6, 2023

  • Add a sentence above the vulnerability table that lets the user know whether or not the table has a severity filter applied.

Example: (The table below has been filtered to show High+ severity)

This is a follow-up to 90850a7 which added generated security pages for different severity levels. security-m.html (Medium), security-h.html (High) and security-c.html (Critical).

When I google search for curl cves the second result is a link to security-h.html. It may not be immediately obvious that the table is filtered and not showing all vulnerabilities.

Closes #xxxx


I don't have a build curl-www to see the output so I'm not 100% sure this is correct

- Add a sentence above the vulnerability table that lets the user know
  whether or not the table has a severity filter applied.

Example: (The table below has been filtered to show High+ severity)

This is a follow-up to 90850a7 which added generated security pages
for different severity levels. security-m.html (Medium),
security-h.html (High) and security-c.html (Critical).

When I google search for `curl cves` the second result is a link
to security-h.html. It may not be immediately obvious that the table is
filtered and not showing all vulnerabilities.

Closes #xxxx
@jay jay added the enhancement label Oct 6, 2023
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly!

@bagder bagder closed this in 2e9f484 Oct 7, 2023
@bagder
Copy link
Member

bagder commented Oct 7, 2023

Thanks!

@jay jay deleted the severity_filter branch October 12, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants