Skip to content

Commit

Permalink
CVE-2023-38545.md: add additional info
Browse files Browse the repository at this point in the history
RyotaK found a way to exploit the bug by crafting a hostname so that the
SOCKS connection completes successfully but to a different hostname and
port, and possibly arbitrary data is sent to that different host before
the "expected" request is sent on that same connection.

The impact is limited because control characters and null are not
allowed in the hostname.

Ref: https://hackerone.com/ryotak?type=user

Closes #308
  • Loading branch information
jay committed Nov 19, 2023
1 parent 5698ed9 commit ac5cb07
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/scripts/spellcheck.words
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ DNS
dns
dnsop
DoH
DoS
doxygen
drftpd
dsa
Expand Down Expand Up @@ -652,6 +653,7 @@ runtime
Ruslan
rustc
rustls
RyotaK
Sagula
SanDisk
SAS
Expand Down
16 changes: 16 additions & 0 deletions docs/CVE-2023-38545.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,22 @@ Severity: High

HackerOne: https://hackerone.com/reports/2187833

ADDITIONAL INFO
---------------

Since the posting of this advisory, security researcher
[RyotaK](https://hackerone.com/ryotak?type=user) has
[notified](https://github.com/curl/curl-www/pull/308) that even if the buffer
size is large enough to prevent heap overflow an attacker can still use the
integer overflow of hostname length in conjunction with a crafted hostname
longer than 255 characters to make the handshake complete successfully.

In this scenario the crafted hostname contains a destination hostname, port and
arbitrary data. The SOCKS server successfully connects to that host, sends the
arbitrary data and then curl sends the "expected" request data on that same
connection. The impact is limited because curl does not allow control
characters and null in the hostname.

AFFECTED VERSIONS
-----------------

Expand Down

0 comments on commit ac5cb07

Please sign in to comment.