-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per Student Analytics [WIP] #765
base: master
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 276. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job Erin! The graphs look nice and will definitely help professors easily see the analytics better. Also, I liked how you noted you would clean up the code so that there is less duplication :).
Hi Erin, I love the analytics work that you're doing, the graphs are very user-friendly! I'm curious about how you're planning on implementing dates for the x-axis, I noticed that it is weekly columns rn- I wonder what the graphs would look like if professors wanted to see data over a longer period of time, or just certain dates (like right before exams or assignment deadlines..) I'm so excited for when we deploy this feature :) keep up the good work! |
Summary
This PR adds a graph to the professor analytics page to display the number of questions asked by each student. I added it below the per TA analytics graph and used the same format as well.
Professors can search for a student using net ID and hover over the graph to view the office hour location, time, and number of questions asked. If a student asks questions during multiple sessions on the same day, the corresponding bars are stacked on top of each other in the graph.
** The functionality is done but I marked this PR as WIP because I want to go back to clean up my code and create a new component for the per TA/student graph so there is less code duplication.
Test Plan
Notes
Breaking Changes
None