Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per Student Analytics [WIP] #765

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

erin-xu
Copy link
Contributor

@erin-xu erin-xu commented Oct 23, 2023

Summary

This PR adds a graph to the professor analytics page to display the number of questions asked by each student. I added it below the per TA analytics graph and used the same format as well.

Screenshot 2023-10-22 at 7 59 25 PM

Professors can search for a student using net ID and hover over the graph to view the office hour location, time, and number of questions asked. If a student asks questions during multiple sessions on the same day, the corresponding bars are stacked on top of each other in the graph.

Screenshot 2023-10-22 at 8 05 48 PM

** The functionality is done but I marked this PR as WIP because I want to go back to clean up my code and create a new component for the per TA/student graph so there is less code duplication.

Test Plan

  • Check that questions asked are displayed correctly for students across calendar date range and for days with multiple office hour sessions.
  • When a different student is selected, the graph data and student info on the left should update.
  • Check that all students can be found through NetID.
  • Check that dropdown scrolls for a long list of students.
  • Check that student cell is blue when hovered over.
  • Check that dropdown closes when a student is selected or click outside.
  • Check that the y-max of the chart is correct - 8 by default and the max number of questions answered in one day if it exceeds 8.

Notes

Breaking Changes

None

  • I have updated the documentation accordingly.
  • My PR adds a @ts-ignore

@erin-xu erin-xu requested a review from a team as a code owner October 23, 2023 00:25
@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 23, 2023

[diff-counting] Significant lines: 276.

Copy link
Contributor

@jewang25 jewang25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job Erin! The graphs look nice and will definitely help professors easily see the analytics better. Also, I liked how you noted you would clean up the code so that there is less duplication :).

@swang235
Copy link
Contributor

Hi Erin, I love the analytics work that you're doing, the graphs are very user-friendly! I'm curious about how you're planning on implementing dates for the x-axis, I noticed that it is weekly columns rn- I wonder what the graphs would look like if professors wanted to see data over a longer period of time, or just certain dates (like right before exams or assignment deadlines..)

I'm so excited for when we deploy this feature :) keep up the good work!

@Sydney-tran Sydney-tran mentioned this pull request Nov 2, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants