Coffee Chat: Suggestions for Categories with No Submissions #680
Conversation
|
[diff-counting] Significant lines: 122. |
|
I see this in the deploy preview: |
backend/src/dao/CoffeeChatDao.ts
Outdated
| @@ -172,4 +173,16 @@ export default class CoffeeChatDao extends BaseDao<CoffeeChat, DBCoffeeChat> { | |||
| static async deleteMemberProperties(email: string): Promise<void> { | |||
| memberPropertiesCollection.doc(email).delete(); | |||
| } | |||
|
|
|||
| /** | |||
| * Gets a mapping of all categories to corresponding members, given the semester | |||
There was a problem hiding this comment.
Maybe add a note here that this data could be up to X number of days stale? So changes made to member info or category info aren't immediately reflected here.
Also, how is this data populated initially? It might be good to have a script that refreshes this data once a day.
This is what I see in the deploy preview. Is this because the prod DB doesn't have the data populated yet? Maybe get a script together that writes the data, test it on the dev DB, and if you're sure it works (should be safe since it's modifying a collection that's not in use yet), then run that script on the prod DB (let me know if you need help with this last part)?
|
Also, I think even after you populate the data in the DB, we still might want to change the error handling here. In particular, how about we just don't show any suggestions at all (instead of the loud error) instead of putting up an error modal each time the loading fails? |
frontend/src/API/CoffeeChatAPI.ts
Outdated
| public static async getCategoryToMembers(semester: string): Promise<BingoBoard> { | ||
| const res = APIWrapper.get(`${backendURL}/bingo-board/${semester}`).then((res) => res.data); | ||
| return res.then((val) => { | ||
| if (val.error) { |
There was a problem hiding this comment.
We could move this error handling to wherever its used in the UI. I think it should be the UI who gets to decide how to handle this. getCategoryToMembers should just return the promise (could be pending/fulfilled/rejected).
The I might format this function the same way the other ones above are, and just return the promise.
Hm, noticed that "a lead (not your role)" isn't showing any suggestions, even though I'd expect at least a few
|
Fixed! |
patriciaahuang
force-pushed
the
coffee-chat-suggestions
branch
from
5ab3173 to
9aa1a34
Compare
Summary
This PR lists all members who meet a category if there is no submission in that category yet. The members listed won't already have a pending/approved coffee chat with the submitter, and won't be the submitter themselves.
Requires addition of
coffee-chat-bingo-boardcollection, with documents formatted like 'fall-2024' to store boards from multiple semesters. Each document has formatcategory: [{netid: __, name: __}]Demo
Screen.Recording.2024-11-11.at.7.06.19.PM.mov
Notion/Figma Link
https://www.notion.so/Coffee-Chat-Suggestions-for-Categories-with-No-Submissions-13c0ad723ce1804ab3c0d35531f4112b?pvs=4