Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IDOL, shoutouts] - edit shoutouts #578

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

[IDOL, shoutouts] - edit shoutouts #578

wants to merge 16 commits into from

Conversation

kevinmram
Copy link
Contributor

@kevinmram kevinmram commented Feb 12, 2024 •
edited
Loading

added a button and functions for editing shoutouts , allowing users to edit their shoutouts after submission.

  • implemented the (Edit) button.
  • implemented the (editShoutout, updateShoutout) functions.
  • display the updated shoutout- without reversion after a refresh.
editing-shoutout.mp4

@dti-github-bot
Copy link
Member

dti-github-bot commented Feb 12, 2024 •
edited
Loading

[diff-counting] Significant lines: 124.

patriciaahuang
patriciaahuang reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@patriciaahuang patriciaahuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I left a note about how to pass the last check. Also, it might be helpful to link the Notion ticket and an image for what you see on your end (edit button, success/error messages, etc), so reviewers can quickly check that we're see the same thing.

frontend/src/components/Forms/ShoutoutsPage/ShoutoutCard.tsx Outdated Show resolved Hide resolved
@kevinmram kevinmram changed the title editing-shoutout - init_imp. editing-shoutout(s) Sep 24, 2024
@kevinmram kevinmram marked this pull request as ready for review September 24, 2024 22:04
@kevinmram kevinmram requested a review from a team as a code owner September 24, 2024 22:04
@kevinmram kevinmram changed the title editing-shoutout(s) editing-shoutouts Sep 24, 2024
@andrew032011
Copy link
Collaborator

Screenshot 2024-09-24 at 6 26 30 PM Can you make it so that the spacing around the icon doesn't change as a result of adding this icon? The layout looks a little funky now since the icon is larger than the trash icon.

andrew032011
andrew032011 reviewed Sep 24, 2024
View reviewed changes
backend/src/dao/ShoutoutsDao.ts Outdated Show resolved Hide resolved
backend/src/API/shoutoutAPI.ts Outdated Show resolved Hide resolved
frontend/src/components/Forms/ShoutoutsPage/ShoutoutCard.tsx Outdated Show resolved Hide resolved
backend/src/API/shoutoutAPI.ts Show resolved Hide resolved
patriciaahuang
patriciaahuang reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@patriciaahuang patriciaahuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall functionality looks good! I agree with what Andrew said about using updateShoutouts instead of creating a new function. Also left a comment to help keep the DAO layer consistent.

backend/src/dao/ShoutoutsDao.ts Outdated Show resolved Hide resolved
@kevinmram kevinmram changed the title editing-shoutouts [IDOL, shoutouts] - edit shoutouts Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriciaahuang patriciaahuang patriciaahuang left review comments

@andrew032011 andrew032011 Awaiting requested review from andrew032011

At least 1 approving review is required to merge this pull request.

Assignees

@kevinmram kevinmram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kevinmram @dti-github-bot @andrew032011 @patriciaahuang @keverie