Fix modal resizing #498
Open
Fix modal resizing #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added ability to specify whether or not options should appear from top or bottom in select dropdowns (now, major menu appears from the top so it doesn't spill off the window).
|
[diff-counting] Significant lines: 27. |
|
does anyone have insight why this test is failing? not really sure what it means |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When adding a lot of majors or resizing text window, modal is now scrollable with hidden scrollbar.
PR Type
Mobile + Desktop Screenshots & Recordings
fix-modal-resizing.mp4
QA - Test Plan
Tested on variety of screen sizes/modes, appears to function similarly on mobile and work more effectively on desktop.
Breaking Changes & Notes
Major options now appear from the top like the grades. They would previously spill off the modal screen, which is kinda ugly and also problematic when scrolling is involved.
Added to documentation?
What GIF represents this PR?
gif