Filter by prof on course page #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Known problem: At very small dim, filter overflows beyond background
|
|
|
[diff-counting] Significant lines: 91. |
qiandrewj
reviewed
Dec 26, 2024
| <h2 className={styles.title}>Past Reviews ({courseReviews?.length}) </h2> | ||
| <h2 className={styles.title}> | ||
| Past Reviews ( | ||
| {selectedProf.current !== 'none' |
There was a problem hiding this comment.
It's more intuitive for me to have it as just visibleCourseReviews.length because otherwise, you might interpret it as being on a second "page" of reviews or something. Can have others give feedback too
There was a problem hiding this comment.
oh wait this makes a lot of sense!! my logic behind this was that i wanted a way to make sure that users easily know that when a professor is selected they're not seeing all the reviews (esp b/c the statistics on the left sidebar are based on all reviews). i think just changing the number itself works though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR works on the filter by professor course page dropdown.
PR Type
Mobile + Desktop Screenshots & Recordings
https://github.com/user-attachments/assets/702f3af8-4f84-4440-ae53-e0308b45ea3a
QA - Test Plan
Checked on different screen sizes, fixing styles as needed. Looks slightly awkward on mobile since the header brushes up against the text, but they never overlap. Checked on a variety of classes to ensure that all professors were added to the dropdown.
Breaking Changes & Notes
Added to documentation?
What GIF represents this PR?
gif