Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Search/Results Sorting #491

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Updated Search/Results Sorting #491

wants to merge 4 commits into from

Conversation

jacquelinecai
Copy link
Contributor

@jacquelinecai jacquelinecai commented Dec 14, 2024

Summary

This PR works on the course search and results feature.

PR Type

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Mobile + Desktop Screenshots & Recordings

Search Bar:
image
Results:
image
No Results:
image

QA - Test Plan

  • Search up any course in frontend and both search and full result list should be sorted by course number when typing in the shortened subject code (e.g. CS, ECON, MATH, etc.)
  • Uncheck all boxes in semester or level

Breaking Changes & Notes

  • Sorted course by subject and professor list on backend
  • Changed default sorting on results page to be more intuitive
  • Updated rendering for no items that fit filters

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ notion
  • πŸ• ...
  • πŸ“• ...
  • πŸ™… no documentation needed

What GIF represents this PR?

gif

@jacquelinecai jacquelinecai requested a review from a team as a code owner December 14, 2024 07:13
@dti-github-bot
Copy link
Member

dti-github-bot commented Dec 14, 2024

[diff-counting] Significant lines: 60.

Copy link
Contributor

@qiandrewj qiandrewj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good -- from testing, the fact that earlier numbers come up in the search bar makes a lot more sense! One thing I'm unsure about is for example I noticed that CS 1109 comes up in the search but not in the results, not sure why that's happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants