Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tag content to match figma #481

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Update tag content to match figma #481

merged 1 commit into from
Dec 4, 2024

Conversation

jacquelinecai
Copy link
Contributor

Summary

This PR works on the Similar Courses tag feature.

PR Type

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Mobile + Desktop Screenshots & Recordings

image

QA - Test Plan

  • search up PMA 1141 in the staging db and the first tag should be changed to the format: "Overall: _/5"

Breaking Changes & Notes

  • changed rating tag to "Overall: _/5" to match design in Figma

Added to documentation?

  • 📜 README.md
  • 📓 notion
  • 🍕 ...
  • 📕 ...
  • 🙅 no documentation needed

What GIF represents this PR?

gif

@jacquelinecai jacquelinecai requested a review from a team as a code owner December 3, 2024 06:06
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 12.

qiandrewj
qiandrewj approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@qiandrewj qiandrewj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacquelinecai jacquelinecai merged commit da80d48 into main Dec 4, 2024
4 checks passed
@jacquelinecai jacquelinecai deleted the jac/tag-update branch December 4, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiandrewj qiandrewj qiandrewj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacquelinecai @dti-github-bot @qiandrewj