Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Employee Modal Styling #559

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

selenaliu1
Copy link
Contributor

@selenaliu1 selenaliu1 commented Dec 6, 2024

Summary

This pull request works on transitioning the employee modal styling to Material UI.

  • Added trash button when there is >1 working hours option
  • Can now add multiple working hours times to the same day
  • switched most of modal to material UI
  • Time picker potentially needs to switch to material UI, not pretty rn
  • Switch upload picture to material UI (and make responsive)
  • error messaging for invalid start and end times (i.e. before or after working hours, or overlapping times on the same day?)
  • sometimes adding working hours availability doesn't save/update the employee availability page

Test Plan

Screen.Recording.2024-12-05.at.9.45.48.PM.mov

Notes

**Note: https://mui.com/material-ui/guides/minimizing-bundle-size/ might want to switch imports if there are significantly slower startup times

Breaking Changes

@selenaliu1 selenaliu1 requested a review from a team as a code owner December 6, 2024 03:09
@dti-github-bot
Copy link
Member

dti-github-bot commented Dec 6, 2024

[diff-counting] Significant lines: 464.

Copy link
Contributor

@raissaji raissaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Selena, great work! I like that all Carriage modals are slowly switching to Material UI, the platform is looking more cohesive and clean.

I was testing your branch and noticed some probems:

Screen.Recording.2024-12-08.at.12.46.12.PM.mov

I believe the new feature to add more employee hours only works for when you create new employees. It doesn't work for editing existing employees. The 400 error will probably need some more extensive debugging (for profiles like Matthias, Nam)

@selenaliu1
Copy link
Contributor Author

selenaliu1 commented Dec 8, 2024

thanks for the catch Raissa! Adding and editing availability is definitely a WIP. Commenting so I remember, but for the 400 error, I also found that when I was testing, but I checked the heroku and the same thing happens for when I click on Matthias and Nam so I think that issue is unrelated, but will need to investigate later
ss of heroku after clicking Matthias: Screenshot 2024-12-08 at 2 55 53 PM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants