Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and filter Custom Component #541

Merged
merged 7 commits into from
Nov 11, 2024
Merged

Search and filter Custom Component #541

merged 7 commits into from
Nov 11, 2024

Conversation

Atikpui007
Copy link
Collaborator

@Atikpui007 Atikpui007 commented Oct 17, 2024

Summary

This Pull request is the step to adding a Custom Search and Filtering logic component to the application which can be used for both Drivers and Students.

  • API calls are made in the Parent component to easily pass filtered items to all components that rely on them like pagination, table and cards. These calls are made once and the searching and filtering are done on the client side so as to improve perfomance
  • Search and Filter component is a custom component which handles fuzzy search and more intuitive filtering
  • I added the stats box to improve the user experience so users can know how much data they are working with
  • All logic for searching and filtering is done in the search and filter so as to be generic and work with other sections, all logic for handling the api calls to retrieve the data is done in the parent component.

Checklist

  • Implement Custom Search and Filter Component
  • Fuzzy search
  • Filtering with nested options
  • Add Stats Box
  • Improve styling for stats box and search and filter component
  • Merge with master and move pagination to the parent component of employees

Test Plan

Screen.Recording.2024-11-11.at.2.08.22.AM.mov

Notes

Breaking Changes

Working on design changes to allow the Search And Filter component to look more aesthetic

Mini visual bug in the students page which occurs when clicking on the filter dropdown might be a rendering issue not sure how to fix it suggestions welcome

@Atikpui007 Atikpui007 requested a review from a team as a code owner October 17, 2024 18:16
@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 17, 2024

[diff-counting] Significant lines: 1158. This diff might be too big! Developer leads are invited to review the code.

@namanhboi
Copy link
Contributor

Hi Desmond, I pull the branch and the component works as intended. I'll use this to revamp the search and filter for students and employees in the future.

@Atikpui007 Atikpui007 requested review from namanhboi, selenaliu1 and raissaji and removed request for syoung212 and thuypham03 November 11, 2024 07:07
Copy link
Contributor

@raissaji raissaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Atikpui007 Atikpui007 merged commit bdcf697 into master Nov 11, 2024
6 checks passed
@Atikpui007 Atikpui007 deleted the SearchAndFilter branch November 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants