Kl628/Calendar Announce Modal + Calendar Closing #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 35. |
Atikpui007
requested changes
Oct 22, 2023
There was a problem hiding this comment.
Code looks good and I like how you're attempting to handle the modal behavior based on the button
One suggestion however is instead of focusing on the button you can have an aria-live region that is dependent on the button which could be a hidden element that changes state based on whether the modal is open or closed
see below for an example
Screen.Recording.2023-10-22.at.14.19.59.mov
kevin-lin12
changed the title
Atikpui007
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes 2 issues: calendar modal announcement and calendar not closing properly. Used a hidden ARIA live that lives outside the screen to detect when modal is opened.
Trello Links:
https://trello.com/c/yuxnWqra/494-calendar-closing
https://trello.com/c/m0FGZumO/488-announce-open-close-for-modal
Test Plan
Carriage.Record.mov
Notes
(Oct 26) Successfully implemented ARIA detection when the calendar is opened. However, there are issues with detection when the calendar is closed.
(Nov 6) Successfully fixed issue with calendar modal announcement and fixed issue with calendar not closing properly.
Breaking Changes